Simplified the use of transChoice() #7205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good for me 👍 |
stof
reviewed
Dec 1, 2016
components/translation/usage.rst
Outdated
| ); | ||
|
|
||
| The second argument (``10`` in this example) is the *number* of objects being | ||
| described and is used to determine which translation to use and also to populate | ||
| the ``%count%`` placeholder. | ||
|
|
||
| .. note:: |
There was a problem hiding this comment.
shouldn't this use a ..versionadded directive ?
components/translation/usage.rst
Outdated
| @@ -255,14 +255,27 @@ To translate pluralized messages, use the | ||
|
|
||
| $translator->transChoice( | ||
| 'There is one apple|There are %count% apples', | ||
| 10, | ||
| array('%count%' => 10) |
There was a problem hiding this comment.
do you still have any example passing other placeholders to transchoice ?
There was a problem hiding this comment.
Using the translator page has a first section about this (http://symfony.com/doc/2.7/components/translation/usage.html#message-placeholders).
|
👍 |
|
Thank you Javier. |
weaverryan
added a commit
that referenced
this pull request
May 20, 2017
* 3.2: (39 commits) updating instance Avoid backticks in shell scripts Update optional_dependencies.rst Fix xml blocks pass only strings to loadUserByUsername() Fix Authenticator Class (getCredentials) example Documented addAnnotatedClassesToCompile() and the use of class patterns Added the picture that shows how GuardAuthenticationListener calls Authentication Guard methods. [#7205] minor tweak Simplified the use of transChoice() [#7875] minor tweaks Minor fix Minor changes Properly show all events and describe guard events [#7891] remove not needed sentence [#7773] fix line length Add helpful remarks on custom DataCollector Remove use of deprecated security.exception_listener.class parameter Update resources.rst Fix incoherent ut8mb4 collation in Doctrine setup ...
weaverryan
added a commit
that referenced
this pull request
May 20, 2017
* 3.4: (40 commits) Adding an article to explain the 3.3 changes, and how to upgrade updating instance Avoid backticks in shell scripts Update optional_dependencies.rst Fix xml blocks pass only strings to loadUserByUsername() Fix Authenticator Class (getCredentials) example Documented addAnnotatedClassesToCompile() and the use of class patterns Added the picture that shows how GuardAuthenticationListener calls Authentication Guard methods. [#7205] minor tweak Simplified the use of transChoice() [#7875] minor tweaks Minor fix Minor changes Properly show all events and describe guard events [#7891] remove not needed sentence [#7773] fix line length Add helpful remarks on custom DataCollector Remove use of deprecated security.exception_listener.class parameter Update resources.rst ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7172.
I'm not happy with the result, so I'm open to comments to improve this. Thanks!