Fixed a typo in "define commands as service" #7124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: Reviewed |
|
👍 it makes sense! Thanks Robin. |
|
Thanks Robin! |
wouterj
added a commit
that referenced
this pull request
Nov 10, 2016
This PR was merged into the 2.7 branch. Discussion ---------- Fixed a typo in "define commands as service" In the introduction of this chapter, we are explaining the restrictions of the "normal" way to register commands, before showing that defining them as services can solve these problems, so at this point we don't talk about a service but a basic command. Commits ------- 43ecb46 Fixed a typo in "define commands as service"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the introduction of this chapter, we are explaining the restrictions of the "normal" way to register commands, before showing that defining them as services can solve these problems, so at this point we don't talk about a service but a basic command.