Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Call isSubmitted() before calling isValid() #7119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Call isSubmitted() before calling isValid() #7119

wants to merge 2 commits into from

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Nov 5, 2016

Forward-compatibility fix

@xabbuh
Copy link
Member

xabbuh commented Nov 6, 2016

Do we do this everywhere else in the docs for Symfony 2.7? If so, are there other places we will have to update too?

@wouterj
Copy link
Member

wouterj commented Nov 6, 2016 •
edited
Loading

👍
status: reviewed

A quick git grep "isValid()" shows there are more cases that needs to be fixed. Imo, this PR can be merged as is (and we can create a follow up PR fixing the other ones). However, if you have time, you can also include the other fixes in this PR.

best_practices/forms.rst:for clarity. This isn't technically needed, since ``isValid()`` first calls
components/form.rst:        if ($form->isValid()) {
components/form.rst:            if ($form->isValid()) {
controller.rst:        if ($form->isValid()) {
controller/upload_file.rst:        if ($form->isValid()) {
form/direct_submit.rst:        if ($form->isValid()) {
form/direct_submit.rst:            if ($form->isValid()) {
form/direct_submit.rst:            if ($form->isValid()) {
form/dynamic_form_modification.rst:            if ($form->isValid()) {
form/form_collections.rst:            if ($form->isValid()) {
form/form_collections.rst:            if ($editForm->isValid()) {
form/multiple_buttons.rst:    if ($form->isValid()) {
form/without_class.rst:        if ($form->isValid()) {
reference/forms/types/file.rst:        if ($form->isValid()) {
security/acl.rst:            if ($form->isValid()) {

@yceruto
Copy link
Member Author

yceruto commented Nov 6, 2016

Okay, I'll do it.

@yceruto
Copy link
Member Author

yceruto commented Nov 6, 2016

Updated!

Status: Needs Review

@wouterj
Copy link
Member

wouterj commented Nov 6, 2016

Awesome! Thanks for the great work & quick response!

status: reviewed

@javiereguiluz
Copy link
Member

👍

@wouterj
Copy link
Member

wouterj commented Nov 10, 2016

Thanks. It's much better now!

wouterj added a commit that referenced this pull request Nov 10, 2016
@wouterj
minor #7119 Call isSubmitted() before calling isValid() (yceruto)
36f9dd7 
This PR was squashed before being merged into the 2.7 branch (closes #7119).

Discussion
----------

Call isSubmitted() before calling isValid()

Forward-compatibility fix

Commits
-------

995e2d9 Call isSubmitted() before calling isValid()
@wouterj wouterj closed this Nov 10, 2016
@yceruto yceruto deleted the patch-1 branch November 10, 2016 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yceruto @xabbuh @wouterj @javiereguiluz @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.