-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Minor changes throughout Best Practices for Reusable Bundles #7118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d145034
Minor changes throughout BP for Reusable Bundles
darrylhein f749f0d
Removing trailing space
darrylhein 16d5d39
Reverting previous grammar change
darrylhein 592b9d2
reword the documentation section re Resources/doc
darrylhein 99dc9a9
add mention of symfony.com re folder structure
darrylhein ae29ce8
Removed backticks from bundle names
javiereguiluz 07dd260
Reverted the changes about bundle namespaces
javiereguiluz 73d2d7c
Better explain the purpose of the "license" Composer metadata
javiereguiluz 5cbb6e8
Update best_practices.rst
HeahDude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add mention of symfony.com re folder structure
- Loading branch information
commit 99dc9a96cb96c7e264d951ddcb103694ef80ba9b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sentence in braces looks wrong to me. Providing doc is required when sharing your bundle. the sentence looks like doc is required only when showing it on symfony.com
Putting it inside
Resources/doc/
and using rST is what is required when rendering it on symfony.com.when rendering the doc elsewhere, we could live with the doc being elsewhere (in a
docs
folder at the root of the repo for instance, which is a convention supported by github pages now) and in any format (as long as you provide a version readable by humans somewhere, and link to it)