Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Minor changes throughout Best Practices for Reusable Bundles #7118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Prev Previous commit
Next Next commit
add mention of symfony.com re folder structure
  • Loading branch information
darrylhein authored Nov 16, 2016
commit 99dc9a96cb96c7e264d951ddcb103694ef80ba9b
3 changes: 2 additions & 1 deletion 3 bundles/best_practices.rst
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,8 @@ Documentation
All classes and functions must come with full PHPDoc.

Extensive documentation should also be provided in the ``Resources/doc/``
directory. The index file (for example ``Resources/doc/index.rst`` or
directory (though only required when the documentation is shown on symfony.com).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sentence in braces looks wrong to me. Providing doc is required when sharing your bundle. the sentence looks like doc is required only when showing it on symfony.com

Putting it inside Resources/doc/ and using rST is what is required when rendering it on symfony.com.
when rendering the doc elsewhere, we could live with the doc being elsewhere (in a docs folder at the root of the repo for instance, which is a convention supported by github pages now) and in any format (as long as you provide a version readable by humans somewhere, and link to it)

The index file (for example ``Resources/doc/index.rst`` or
``Resources/doc/index.md``) is the only mandatory file and must be the entry
point for the documentation. The
:doc:`reStructuredText (rST) </contributing/documentation/format>` is the most
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.