Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Remove AssetsHelper from the templating component #7101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Remove AssetsHelper from the templating component #7101

wants to merge 4 commits into from

Conversation

alexpts
Copy link
Contributor

@alexpts alexpts commented Oct 30, 2016 •
edited
Loading

deprecated since 2.7, will be removed in 3.0. Use the Asset component instead.

@alexpts alexpts changed the title Component has only one helper in real Remove AssetsHelper from the templating component Oct 30, 2016
wouterj
wouterj reviewed Nov 1, 2016
View reviewed changes
components/templating.rst
@@ -139,9 +139,8 @@ Helpers

The Templating component can be easily extended via helpers. Helpers are PHP objects that
provide features useful in a template context. The component has
2 built-in helpers:
a built-in helper:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The component has one helper built-in:" ? (I'm not a native, but it sounds a bit better to me)

@wouterj
Copy link
Member

wouterj commented Nov 1, 2016

👍
status: reviewed

@wouterj
Copy link
Member

wouterj commented Nov 1, 2016

If you have some time left, please also remove the /components/templating/assetshelper article (and the references to it).

@alexpts
Copy link
Contributor Author

alexpts commented Nov 1, 2016

Ok, I ll pull project and prepare full PR for remove all deps.

@alexpts
Copy link
Contributor Author

alexpts commented Nov 1, 2016 •
edited
Loading

PR is ready.
I think it need apply to 3.0 branch also.

@xabbuh
Copy link
Member

xabbuh commented Nov 5, 2016

Thank you @alexpts.

xabbuh added a commit that referenced this pull request Nov 5, 2016
@xabbuh
minor #7101 Remove AssetsHelper from the templating component (alexpts)
0bb20a5 
This PR was squashed before being merged into the 3.1 branch (closes #7101).

Discussion
----------

Remove AssetsHelper from the templating component

> > deprecated since 2.7, will be removed in 3.0. Use the Asset component instead.

Commits
-------

4a17054 Remove AssetsHelper from the templating component
@xabbuh xabbuh closed this Nov 5, 2016
@alexpts
Copy link
Contributor Author

alexpts commented Nov 5, 2016

I think it need apply to 3.0/3.2 branch also.

@xabbuh
Copy link
Member

xabbuh commented Nov 5, 2016

Symfony 3.0 does not receive bug fixes anymore. That's why we also do not update the documentation for it any longer. So I have merged your PR into the 3.1 branch after squashing it and merged it up to master from there. This means that your fix will be part of the documentation for all versions starting with 3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj left review comments

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexpts @wouterj @xabbuh @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.