Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[#6947] some minor tweaks #7075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2016
Merged

[#6947] some minor tweaks #7075

merged 1 commit into from
Nov 5, 2016

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 21, 2016

No description provided.

@wouterj
Copy link
Member

wouterj commented Oct 21, 2016

👍
status: reviewed

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

each cached items. Each tag is a plain string identifier that you can use at any
time to trigger the removal of all items that had this tag attached to them.
each cached item. Each tag is a plain string identifier that you can use at any
time to trigger the removal of all items that have this tag attached to them.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all items that have this tag attached to them. -> all items associated with this tag. ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


// invalidate all items related to `tag_1` or `tag_3`
$cache->invalidateTags(array('tag_1', 'tag_3'));

// if you know the cache key, you can of course delete directly
// if you know the cache key, you can of course delete the item directly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove of course in this comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because terms like "of course", "very easy", "just...", "easily", "simply", etc. are patronizing and most of the times, redundant.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, updated here too.

@javiereguiluz
Copy link
Member

Great! Ready to be merged. Thanks @xabbuh.

@xabbuh xabbuh merged commit f865f93 into symfony:master Nov 5, 2016
xabbuh added a commit that referenced this pull request Nov 5, 2016
This PR was merged into the master branch.

Discussion
----------

[#6947] some minor tweaks

Commits
-------

f865f93 [#6947] some minor tweaks
@xabbuh xabbuh deleted the pr-6947 branch November 5, 2016 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.