Added support for standard Forwarded header #4266
Conversation
There was a problem hiding this comment.
I think this shouldn't be the last section on the page.
There was a problem hiding this comment.
@xabbuh What would you advise? Moving those two lines above the paragraph?
There was a problem hiding this comment.
I would move it below the first paragraph you modified.
There was a problem hiding this comment.
Okay indeed it makes more sense at the top.
|
👍 |
|
I forgot to review this one and only commented on @cordoval's comment. I've added 2 minor comments, once those are fixed, Ill label it as "finished". Thanks! |
|
Hi @tony-co. Do you have time to update this PR? Don't worry if you don't have time soon, there will be a doc sprint day on May 23rd. During that day, we want to finish as much PRs as possible. Maybe you can join in then or we can hand it over to someone else on that day if you want :) |
|
This PR has been completed in #5382. |
…aviereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Added support for standard Forwarded header | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.7+ | Fixed tickets | - This PR finishes the work made by @tony-co in #4266. Commits ------- 8928049 Fixed a minor grammar issue 319c081 Fixed a minor grammar issue ac3689b Added support for standard Forwarded header d452137 Added support for standard Forwarded header
Refs symfony/symfony#11379