Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Added link to JSFiddle example #4125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weaverryan merged 1 commit into from
Aug 16, 2014
Merged

Added link to JSFiddle example #4125

weaverryan merged 1 commit into from
Aug 16, 2014

Conversation

@wouterj
Copy link
Member

@wouterj wouterj commented Aug 16, 2014

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #3853

@xabbuh
Copy link
Member

xabbuh commented Aug 16, 2014

Can we guarantee that the snippet is never modified by someone else?

@wouterj
Copy link
Member Author

wouterj commented Aug 16, 2014

Yes, if someone modifies it, it'll create a new fork (so another url) or a new version (so another url too)

@xabbuh
Copy link
Member

xabbuh commented Aug 16, 2014

Do you get notifications in case someone modifies it?

@wouterj
Copy link
Member Author

wouterj commented Aug 16, 2014

No and it shouldn't make any sense to get those imo

@xabbuh
Copy link
Member

xabbuh commented Aug 16, 2014

This means that we have to check the example frequently, doesn't it?

@wouterj
Copy link
Member Author

wouterj commented Aug 16, 2014

This means that we have to check the example frequently, doesn't it?

Why? "if someone modifies it, it'll create a new fork (so another url) or a new version (so another url too)"

@xabbuh
Copy link
Member

xabbuh commented Aug 16, 2014

Sorry, I read "I'll" and not "it'll".

@weaverryan
Copy link
Member

weaverryan commented Aug 16, 2014

This is awesome - thanks Wouter!

@weaverryan weaverryan merged commit fe53a3f into symfony:2.3 Aug 16, 2014
weaverryan added a commit that referenced this pull request Aug 16, 2014
@weaverryan
feature #4125 Added link to JSFiddle example (WouterJ)
4d5adaa 
This PR was merged into the 2.3 branch.

Discussion
----------

Added link to JSFiddle example

| Q   | A
| --- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | all
| Fixed tickets | #3853

Commits
-------

fe53a3f Added link to JSFiddle example
@wouterj wouterj deleted the add_jsfiddle branch August 16, 2014 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: Reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wouterj @xabbuh @weaverryan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.