Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

eraseCredentials method typo #4059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

eraseCredentials method typo #4059

wants to merge 1 commit into from

Conversation

danielsan
Copy link
Contributor

No description provided.

@weaverryan
Copy link
Member

Nice catch Daniel! Cheers!

weaverryan added a commit that referenced this pull request Jul 30, 2014
@weaverryan
minor #4059 ��eraseCredentials method typo (danielsan)
b3f15b2 
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #4059).

Discussion
----------

��eraseCredentials method typo

Commits
-------

819c588 ��eraseCredentials method typo
@wouterj wouterj closed this Jul 30, 2014
@wouterj
Copy link
Member

wouterj commented Jul 30, 2014

hmmm, GH seems to not close PRs sometimes, @fabpot

@weaverryan
Copy link
Member

I'll keep a closer eye when I'm merging...

@stof
Copy link
Member

stof commented Aug 5, 2014

@weaverryan when you rebase a PR (or squash it as this implies a rebase), the PR is not considered as merged by github, which is logical. The merge commit created by GH contains closes #XXX to close the PR automatically even in this case, but this has an effect only when the commit reaches the default branch. So it would have been closed automatically when merging 2.3 into master. If you don't want to wait, you indeed need to close it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielsan @weaverryan @wouterj @stof
Morty Proxy This is a proxified and sanitized view of the page, visit original site.