Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Command] Added LockHelper #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weaverryan merged 2 commits into from
Oct 18, 2014
Merged

[Command] Added LockHelper #3956

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bf8c55
[Filesystem] Moved current document to a dedicated folder
lyrixx Sep 22, 2014
909a294
[Filesystem] Added documentation for the new LockHandler
lyrixx Sep 22, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Filesystem] Moved current document to a dedicated folder
  • Loading branch information
@lyrixx
lyrixx committed Oct 18, 2014
commit 2bf8c55a79474a3750c92891797969c706e59528
21 changes: 2 additions & 19 deletions 21 components/filesystem.rst → components/filesystem/filesystem.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,5 @@
.. index::
single: Filesystem

The Filesystem Component
========================

The Filesystem component provides basic utilities for the filesystem.

.. versionadded:: 2.1
The Filesystem component was introduced in Symfony 2.1. Previously, the
``Filesystem`` class was located in the HttpKernel component.

Installation
------------

You can install the component in 2 different ways:

* :doc:`Install it via Composer </components/using_components>` (``symfony/filesystem`` on `Packagist`_);
* Use the official Git repository (https://github.com/symfony/Filesystem).
Filesystem
Copy link
Member

@wouterj wouterj Sep 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why didn't you add this to the introduction chapter?

Copy link
Member Author

@lyrixx lyrixx Sep 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep consistency with other document.

Copy link
Member

@xabbuh xabbuh Sep 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually have some basic usage instructions on the introduction page.

==========

Usage
-----
Expand Down
9 changes: 9 additions & 0 deletions 9 components/filesystem/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Filesystem
==========

.. toctree::
:maxdepth: 2

introduction
filesystem
lockhandler
16 changes: 16 additions & 0 deletions 16 components/filesystem/introduction.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
The Filesystem Component
========================

The Filesystem component provides basic utilities for the filesystem.

.. versionadded:: 2.1
The Filesystem component was introduced in Symfony 2.1. Previously, the
``Filesystem`` class was located in the HttpKernel component.

Installation
------------

You can install the component in 2 different ways:

* :doc:`Install it via Composer </components/using_components>` (``symfony/filesystem`` on `Packagist`_);
Copy link
Member

@xabbuh xabbuh Sep 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also have to move the URL for Packagist from filesystem.rst to the end of this file.

Copy link
Member Author

@lyrixx lyrixx Sep 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I should move all content from filesystem.rst to introduction.rst?

Copy link
Member

@xabbuh xabbuh Sep 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think I'd actually prefer that.

Copy link
Member Author

@lyrixx lyrixx Sep 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done ;)

* Use the official Git repository (https://github.com/symfony/Filesystem).
2 changes: 2 additions & 0 deletions 2 components/filesystem/lockhandler.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Lockhandler
Copy link
Member

@xabbuh xabbuh Sep 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "LockHandler" (like the class name) or "Lock Handler".

===========
2 changes: 1 addition & 1 deletion 2 components/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ The Components
dom_crawler
event_dispatcher/index
expression_language/index
filesystem
filesystem/index
finder
form/index
http_foundation/index
Expand Down
1 change: 1 addition & 0 deletions 1 redirection_map
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
/cookbook/console/generating_urls /cookbook/console/sending_emails
/components/yaml /components/yaml/introduction
/components/templating /components/templating/introduction
/components/filesystem /components/filesystem/introduction
/cmf/reference/configuration/block /cmf/bundles/block/configuration
/cmf/reference/configuration/content /cmf/bundles/content/configuration
/cmf/reference/configuration/core /cmf/bundles/core/configuration
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.