Updated event_listener.rst

Updated event_listener.rst to use the new KernelEvent::isMasterRequest method
symfony · weaverryan · May 27, 2014 · Apr 7, 2014 · Apr 8, 2014 · Apr 10, 2014
commit 0127bd24ccd3face99a94de0aa96f96deac7a47e
diff --git a/cookbook/service_container/event_listener.rst b/cookbook/service_container/event_listener.rst
@@ -115,7 +115,7 @@ done as follow::
    {
        public function onKernelRequest(GetResponseEvent $event)
        {
-            if (HttpKernel::MASTER_REQUEST != $event->getRequestType()) {
+            if (false === $event->isMasterRequest()) {
                // don't do anything if it's not the master request
                return;
            }
-Original file line number
+Diff line change
@@ -115,7 +115,7 @@ done as follow::
         {
             public function onKernelRequest(GetResponseEvent $event)
             {
-                if (HttpKernel::MASTER_REQUEST != $event->getRequestType()) {
+                if (false === $event->isMasterRequest()) {
             Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            stof
  

      

      

      


        Apr 8, 2014


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      should be if (!$event->isMasterRequest()) { to follow the coding standards (we don't do a strict check comparison for methods which already return a boolean, except when we need to distinguish false and 0 for strpos or similar functions)
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
                     // don't do anything if it's not the master request
                     return;
                 }
-          Expand Down