[PropertyInfo] Deprecate Type
#20821
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Mar 25, 2025
OskarStark
reviewed
Mar 25, 2025
|
friendly ping @mtarld |
mtarld
suggested changes
Mar 25, 2025
| @@ -303,32 +305,32 @@ Each object will provide 6 attributes, available in the 6 methods: | ||
| ``Type::getBuiltInType()`` |
There was a problem hiding this comment.
All of these methods are kind of removed:
getBuiltinTypeis the same asgetTypeIdentifierofBuiltinTypeandObjectTypeisNullablestill existsgetClassNameonly exists onObjectTypeisCollectionis the equivalent of$type instanceof CollectionTypegetCollection[Key|Value]Typesis the same asgetCollection[Key|Value]TypeofCollectionType
The Type of TypeInfo is really different from the one from PropertyInfo, so I think we might rewrite that part completely.
Or maybe redirect to the doc related to TypeInfo's Type?
There was a problem hiding this comment.
Thanks, I missed those differences.
Maybe we can remove this part from PropertyInfo Type doc as the class is deprecated and update TypeInfo doc with appropriate methods ?
There was a problem hiding this comment.
I would also not mix the TypeInfo things into the doc of PropertyInfo
Co-authored-by: Oskar Stark <oskarstark@googlemail.com> Co-authored-by: Mathias Arlaud <mathias.arlaud@gmail.com>
mtarld
suggested changes
Mar 29, 2025
Comment on lines
+172
to
+177
| private $builtinType => string(6) "string" | ||
| private $nullable => bool(false) | ||
| private $class => NULL | ||
| private $collection => bool(false) | ||
| private $collectionKeyType => NULL | ||
| private $collectionValueType => NULL |
There was a problem hiding this comment.
This is not what the Type class (from type-info) contains.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20799