Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Routing] add mapped route parameters and aliases #20812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[Routing] add mapped route parameters and aliases #20812

wants to merge 8 commits into from
+78 −0

Conversation

eltharin
Copy link
Contributor

@eltharin eltharin commented Mar 24, 2025 •
edited
Loading

Fix: #20806

Add documentation for Mapped Route Parameters and Aliased Mapped route parameters :
symfony/symfony#59904

@carsonbot carsonbot added this to the 7.3 milestone Mar 24, 2025
@eltharin eltharin force-pushed the mappedrouteparameters branch from 5025b48 to e37a9dc Compare March 24, 2025 17:30
@carsonbot carsonbot changed the title add mapped route parameters and aliases [Routing] add mapped route parameters and aliases Mar 24, 2025
OskarStark
OskarStark reviewed Mar 24, 2025
View reviewed changes
doctrine.rst Outdated Show resolved Hide resolved
OskarStark
OskarStark reviewed Mar 24, 2025
View reviewed changes
doctrine.rst Outdated Show resolved Hide resolved
OskarStark
OskarStark reviewed Mar 24, 2025
View reviewed changes
doctrine.rst Outdated Show resolved Hide resolved
MrYamous
MrYamous reviewed Mar 24, 2025
View reviewed changes
doctrine.rst Outdated Show resolved Hide resolved
@eltharin @MrYamous
Update doctrine.rst
a60587c 
Co-authored-by: Matthieu Lempereur <matt.lempereur@gmail.com>
MrYamous
MrYamous reviewed Mar 25, 2025
View reviewed changes
doctrine.rst Outdated Show resolved Hide resolved
MrYamous
MrYamous reviewed Mar 25, 2025
View reviewed changes
doctrine.rst Outdated Show resolved Hide resolved
@eltharin eltharin requested a review from OskarStark April 18, 2025 11:04
@nicolas-grekas nicolas-grekas mentioned this pull request May 12, 2025
Merged
javiereguiluz added a commit that referenced this pull request May 20, 2025
@javiereguiluz
minor #20956 [Routing] Tell about {foo:bar} mapping syntax (nicolas…
2d7393a 
…-grekas)

This PR was merged into the 7.2 branch.

Discussion
----------

[Routing] Tell about `{foo:bar}` mapping syntax

Fix #20806
Fix #19846
Fix #19848
Replaces #19869
Replaces #20812

Commits
-------

e591c59 [Routing] Tell about {foo:bar} mapping syntax
@javiereguiluz
Copy link
Member

@eltharin thanks a lot for this contribution. Although your proposal is technically correct, sadly we have to close it without merging because we came up with an alternative PR (#20956) that also fixed other minor issues in routing docs. Sorry!

@eltharin
Copy link
Contributor Author

@javiereguiluz no problem, what about #20820 ? Should I continue it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrYamous MrYamous MrYamous left review comments

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
Routing Status: Needs Review
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[Routing] Add alias in {foo:bar} syntax in route parameter
5 participants
@eltharin @javiereguiluz @OskarStark @MrYamous @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.