[Notifier][Webhook] Added documentation for Webhook in combination with the Notifier component #19269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9d9033 to
f952f85
Compare
|
Requesting a PR review from @OskarStark and @alexandre-daubois since we're all working on parts of this. |
f952f85 to
e6d0506
Compare
OskarStark
reviewed
Dec 12, 2023
|
Rebase unlocked @TimoBakx ✅ |
e6d0506 to
208de86
Compare
|
@OskarStark rebased, but the other PR targetted 6.4, this one targets 6.3. |
|
I can fix that in a PR for 6.4, where I will also add Vonage to the list. So that's fine for this PR. 👍 |
OskarStark
reviewed
Dec 12, 2023
208de86 to
af00dcd
Compare
MrYamous
reviewed
Dec 12, 2023
af00dcd to
421ba26
Compare
…th the Notifier component
421ba26 to
31687e4
Compare
|
Thank you Timo. |
|
Upmerged to 7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The consumer slightly differs between the Mailer and Notifier implementations, so I think it is good have a bit of extra documentation for that, separately.