Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Messenger] Add RunProcessMessage, RunCommandMessage and PingWebhookMessage #18631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

[Messenger] Add RunProcessMessage, RunCommandMessage and PingWebhookMessage #18631

merged 1 commit into from
Jul 31, 2023

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Jul 29, 2023 •
edited
Loading

@carsonbot carsonbot added this to the 6.4 milestone Jul 29, 2023
OskarStark
OskarStark reviewed Jul 29, 2023
View reviewed changes
messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
94noni
94noni reviewed Jul 29, 2023
View reviewed changes
messenger.rst Outdated Show resolved Hide resolved
This was referenced Jul 30, 2023
Closed
Closed
@alexandre-daubois alexandre-daubois changed the title [Messenger] Add RunProcessMessage [Messenger] Add RunProcessMessage, RunCommandMessage and PingWebhookMessage Jul 30, 2023
@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Jul 30, 2023 •
edited
Loading

@OskarStark that's update 👍
@kbond friendly ping, I added RunCommandMessage and PingWebhookMessage 🙂 Thank you for the examples in your PR!

94noni
94noni reviewed Jul 30, 2023
View reviewed changes
messenger.rst Outdated Show resolved Hide resolved
kbond
kbond reviewed Jul 31, 2023
View reviewed changes
messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
messenger.rst
]);
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note similar to above that a ResponseInterface is returned from the handler?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 👍

kbond
kbond reviewed Jul 31, 2023
View reviewed changes
messenger.rst Outdated Show resolved Hide resolved
kbond
kbond reviewed Jul 31, 2023
View reviewed changes
messenger.rst Outdated Show resolved Hide resolved
kbond
kbond approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@javiereguiluz
Copy link
Member

What a great contribution (fixing 3 issues!), what a nice feature and what an amazing review process. Thank you all for being so marvelous 🙇

@javiereguiluz javiereguiluz merged commit 7cc92d5 into symfony:6.4 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@94noni 94noni 94noni left review comments

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
6.4
6 participants
@alexandre-daubois @javiereguiluz @kbond @OskarStark @94noni @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.