[DependencyInjection] Document Container invalid behavior #17903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
commented
Feb 13, 2023
OskarStark
reviewed
Feb 15, 2023
a8b45ad to
6f1a620
Compare
|
Antoine, thanks a lot for taking care of solving this issue (which was first reported in 2017!!). While merging I tweak some things (fd9b155) (change the heading to be consistent with the kind of headings we use in docs; wrap long lines and reorder the options) but your original contribution was great. Thanks. |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Feb 15, 2023
…INVALID_REFERENCE` behavior (alamirault) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Add doc for `RUNTIME_EXCEPTION_ON_INVALID_REFERENCE` behavior | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> While working on documentation of container behaviors symfony/symfony-docs#17903, I saw `RUNTIME_EXCEPTION_ON_INVALID_REFERENCE` was not documented Commits ------- 308e59e [DependencyInjection] Add doc for RUNTIME_EXCEPTION_ON_INVALID_REFERENCE behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try fix #8759
Explanations come from repository
https://github.com/symfony/symfony/blob/8cf5f021fae00975c67a3a50806edbef8bab973b/src/Symfony/Component/DependencyInjection/Container.php#L34-L44
(I will make a PR on symfony to document
RUNTIME_EXCEPTION_ON_INVALID_REFERENCEwhen I will unterstand it)