Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DependencyInjection] 6.0 [injection_types] remove mention of @required in service_container #17655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexislefebvre
Copy link
Contributor

@alexislefebvre alexislefebvre commented Jan 5, 2023

Same logic than in #17654:

Symfony 6+ requires PHP 8, so #[Required] can be used in all cases, and mentioning @required doesn't add any value.

@carsonbot carsonbot added this to the 6.0 milestone Jan 5, 2023
@alexislefebvre alexislefebvre changed the title 6.0 [injection_types] remove mention to required in service_container 6.0 [injection_types] remove mention of @required in service_container Jan 6, 2023
@carsonbot carsonbot changed the title 6.0 [injection_types] remove mention of @required in service_container [DependencyInjection] 6.0 [injection_types] remove mention of @required in service_container Jan 7, 2023
@javiereguiluz
Copy link
Member

Thanks!

@javiereguiluz javiereguiluz merged commit b0d6f80 into symfony:6.0 Jan 7, 2023
@alexislefebvre alexislefebvre deleted the 6.0-remove-mention-to-required-2 branch January 7, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.