Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Adding some information on normalisation and appending sections in a con... #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

richardmiller-zz
Copy link
Contributor

...fig tree

Normalization
-------------

Before the tree is used to validate the configuration some normalization takes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The normalization is done before merging the configs together. And the validation is done after the merging. Your sentence is not enough as it does not talk about the place of the merging in the process

fabpot added a commit to symfony/symfony that referenced this pull request Sep 19, 2012
Commits
-------

1402b42 Fixing config normalisation example in docblock

Discussion
----------

Fixing config normalisation example in docblock

Against 2.0 this time

as per @stof's comments in symfony/symfony-docs#1721

Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: -
Fixes the following tickets: -
Todo: -
License of the code: MIT
@weaverryan
Copy link
Member

Hey Richard!

I'm ready to merge this in - but I see an extra document has slipped in - about DI workflow from #1730. Can you remove that please?

Thanks as always!

@richardmiller-zz
Copy link
Contributor Author

Whoops, removed and rebased

weaverryan added a commit that referenced this pull request Sep 24, 2012
Adding some information on normalisation and appending sections in a con...
@weaverryan weaverryan merged commit 2c3d526 into symfony:2.0 Sep 24, 2012
weaverryan added a commit that referenced this pull request Sep 24, 2012
@weaverryan
Copy link
Member

Hi Richard!

This is an excellent description of a not-so-easy topic. I've merged it in with very minor changes.

Per Stof's 1 remaining comment, do we still need to take more action on this or is the document in its merged state fully correct?

Thanks!

@richardmiller-zz
Copy link
Contributor Author

Its been fixed, I think its still showing as that line didn't change (one was added underneath) so its not considered an outdated diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.