Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix assert statement #16107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2021
Merged

Fix assert statement #16107

merged 1 commit into from
Nov 24, 2021

Conversation

nacholibre
Copy link
Contributor

In my local version of phpunit 9.5.9 $this->assertContains has the following signature:

public static function assertContains($needle, iterable $haystack, string $message = ''): void
{
    //..
}

Where $commandTester->getDisplay(); returns string and the test fails with

TypeError: Argument 2 passed to PHPUnit\Framework\Assert::assertContains() must be iterable, string given, called in..

@carsonbot carsonbot added this to the 4.4 milestone Nov 15, 2021
xabbuh
xabbuh reviewed Nov 17, 2021
View reviewed changes
console.rst Outdated Show resolved Hide resolved
@javiereguiluz
Copy link
Member

Good catch Yoan! Thanks and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit bf1f6c5 into symfony:4.4 Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@nacholibre @javiereguiluz @xabbuh @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.