Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Form] Minor deletion #15992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2022
Merged

[Form] Minor deletion #15992

merged 1 commit into from
Jan 14, 2022

Conversation

ThomasLandauer
Copy link
Contributor

Follow-up of #15982
The point is that it's included in label (not in errors) ;-)

About the syntax: Would it be possible to add a link to RST/Spinx to the "edit" <textarea> on GitHub?

@javiereguiluz
Copy link
Member

javiereguiluz commented Oct 25, 2021

I disagree with this change ... when you click on that link, this is what you see:

Clicking on "Bootstrap 4 form theme" and seeing "Error Messages" can be very confusing.

@ThomasLandauer
Copy link
Contributor Author

First of all: I'm only suggesting to return to the exact situation that we had before I changed it 3 days ago in #15982

When I click the link, I see the "Error Messages" section of the Bootstrap 4 Theme page. This isn't confusing at all, since the caution box is exactly about that: error messages of Bootstrap Theme ;-) What would you expect when you click?

Your text "In the error messages of Bootstrap 4 Form Theme" is wrong, cause it's not the error message that is including something. In fact it's exactly the other way round: The label is including something.

Follow-up of symfony#15982
The point is that it's included in **label** (not in *errors*) ;-)
@wouterj wouterj merged commit 83bdd35 into symfony:4.4 Jan 14, 2022
@wouterj
Copy link
Member

wouterj commented Jan 14, 2022

I agree with both of you, so I decided to reword the message all together to avoid any of the issues mentioned in this PR.

Thanks for the PR @ThomasLandauer

@ThomasLandauer ThomasLandauer deleted the patch-23 branch January 14, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.