Clearify the goal of Bundle::getParent() #1549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method getParent is confusing because there is no parent/child relation. This commit added a note to clearify this
because it isn't relevant at that place
weaverryan
added a commit
that referenced
this pull request
Jul 14, 2012
Clearify the goal of Bundle::getParent()
weaverryan
added a commit
that referenced
this pull request
Jul 14, 2012
|
Hey! It's great - merged in! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method getParent is confusing because there is no parent/child relation. This PR add a note to clearify this.
More information can be found at the Symfony Issue
Please note that English isn't my primary language, so please tell me if I have done something wrong.