Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Testing] Every custom header in functional testing client must have HTTP_ prefix #15191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2021
Merged

[Testing] Every custom header in functional testing client must have HTTP_ prefix #15191

merged 1 commit into from
Apr 6, 2021

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Apr 5, 2021

Due to symfony/symfony#5074 issue, I would propose to add a simple caution block with information, that the HTTP_ prefix is mandatory - it will save some hours for others.

@carsonbot carsonbot changed the title [Testing]Every custom header in functional testing client must have HTTP_ prefix [Testing] Every custom header in functional testing client must have HTTP_ prefix Apr 5, 2021
@javiereguiluz javiereguiluz added this to the 4.4 milestone Apr 6, 2021
@javiereguiluz javiereguiluz changed the base branch from 5.x to 4.4 April 6, 2021 11:34
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner April 6, 2021 11:34
@javiereguiluz javiereguiluz merged commit d4049ed into symfony:4.4 Apr 6, 2021
@javiereguiluz
Copy link
Member

@Ferror thanks for this contribution! We should have added this a long ago.

Note that we merged this in Symfony 4.4 (and all the upper branches) and while merging, we expanded the explanation to give the full details of how the custom headers should be formatted: cc0337c

@Ferror Ferror deleted the doc-custom-header-testing-client branch December 7, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review Testing
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Ferror @javiereguiluz @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.