[Notifier] [LightSMS] add docs #15178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Apr 1, 2021
OskarStark
approved these changes
Apr 5, 2021
OskarStark
approved these changes
Apr 6, 2021
OskarStark
added a commit
to symfony/symfony
that referenced
this pull request
Apr 6, 2021
…, StaffNowa) This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Add LightSms notifier bridge | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | License | MIT | Doc PR | symfony/symfony-docs/pull/15178 | Recipe PR | symfony/recipes#921 LightSms notifier https://github.com/D4DLab/lightsms-notifier Commits ------- 37c665e * LightSmsTransport.php - make fabbot happy 68a12fa * fix tests f1f83b9 * LightSmsTransport.php - use query string parameters 026dcd9 * LightSmsTransport.php - isset 2a9ac2d * LightSmsTransport.php - fix 4213564 * composer.json - fix Fabien comment from another pull request #40646 21e972a * coding standard bea5256 * type cast. On success lightsms return error code like string. On error return integer. 9b2e2d0 * type cast. On success lightsms return error code like string. On error return integer. 0d7488b * type cast. On success lightsms return error code like string. On error return integer. 9a832ef * LightSmsTransport.php - via mistake removed www which return (Closing direction to the user). Removed additional isset which in reality not needed. Added new method which allow to return "unknown error" and throw exception if not successfully 178d9c2 * pull request #40696 95e82f6 Update LightSmsTransport.php a197dee * LightSmsTransport.php - better to remove if we do not have it? 83d2598 * Coding Standard patch 1ff97e4 * LightSmsTransport.php - build signature and use http_build_query, timestamp int 1c993b7 * ERROR_CODES -> int * www. - bug * isset validate ['error'] 1b59a7d * LightSmsTransport.php - string param 58ac708 * LightSmsTransport.php - return back www (without will not work). Now fail tests b9f9ff8 * LightSmsTransport.php - tests fail 265f776 * LightSmsTransport.php - issue with Symfony\Component\Notifier\Bridge\LightSms\Tests\LightSmsTransportTest 23a446a * LightSmsTransport.php - issue with Symfony\Component\Notifier\Bridge\LightSms\Tests\LightSmsTransportTest 08235e5 * LightSmsTransport.php - bug fix 80ef5ba * LightSmsTransport.php - Unable to send the SMS: Closing direction to the user 08b0729 Update LightSmsTransport.php 7180c1f Update LightSmsTransport.php f16b4d2 * phone changed to from 7f13dbf * sender changed to from e20ef1e * LightSmsTransport.php - change + to 00 b0e64b9 * LightSmsTransport.php - not ok throw exception fc13bb2 * LightSmsTransport.php - changed login for validation (the same like we have all places) 5d2e692 * LightSmsTransport.php - escape phone number 8620e82 * LightSmsTransport.php - move timestamp 66c34ba Update README.md 2e0e1d7 Update README.md 7b51e0d Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 079406e Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 0e41bc9 Update src/Symfony/Component/Notifier/Bridge/LightSms/Tests/LightSmsTransportFactoryTest.php 3d0d79c Update src/Symfony/Component/Notifier/Bridge/LightSms/Tests/LightSmsTransportFactoryTest.php e0a68bd Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 1b073c2 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php b0891be Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 49b4780 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php b2e4638 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php c02dbbd Update src/Symfony/Component/Notifier/Bridge/LightSms/README.md 9f89014 Update src/Symfony/Component/Notifier/Bridge/LightSms/README.md 5e54dfe * LightSmsTransport.php - quick fix for private constant. 3cbbc85 * HOST split into two parts 9e1809e * small changes febff46 Update src/Symfony/Component/Notifier/Bridge/LightSms/LICENSE 4a11b94 * github account author 728a3e2 * Transport.php - missing use ce41756 * notifier_transports.php - Coding Standard d1ccd46 * Attached file changes which are required to run the lightsms notifier a0fae7d * tests 15686c0 * LightSmsTransport.php - Coding Standard 2f65b92 * LightSmsTransport.php - Coding Standard 6792535 * composer.json - requirements bug fix 167f325 * LightSmsTransport.php - logic error be8f994 * LightSmsTransport.php - return type f2ba226 * LightSmsTransport.php - bug fix b075c0e * LightSms notifier
symfony-splitter
pushed a commit
to symfony/notifier
that referenced
this pull request
Apr 6, 2021
…, StaffNowa) This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Add LightSms notifier bridge | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | License | MIT | Doc PR | symfony/symfony-docs/pull/15178 | Recipe PR | symfony/recipes#921 LightSms notifier https://github.com/D4DLab/lightsms-notifier Commits ------- 37c665eb5c * LightSmsTransport.php - make fabbot happy 68a12fa4f4 * fix tests f1f83b9e5c * LightSmsTransport.php - use query string parameters 026dcd97a9 * LightSmsTransport.php - isset 2a9ac2d92a * LightSmsTransport.php - fix 4213564be1 * composer.json - fix Fabien comment from another pull request #40646 21e972a69e * coding standard bea5256cc2 * type cast. On success lightsms return error code like string. On error return integer. 9b2e2d0b4a * type cast. On success lightsms return error code like string. On error return integer. 0d7488b10a * type cast. On success lightsms return error code like string. On error return integer. 9a832ef595 * LightSmsTransport.php - via mistake removed www which return (Closing direction to the user). Removed additional isset which in reality not needed. Added new method which allow to return "unknown error" and throw exception if not successfully 178d9c2a5a * pull request #40696 95e82f6ef1 Update LightSmsTransport.php a197deeed1 * LightSmsTransport.php - better to remove if we do not have it? 83d259832b * Coding Standard patch 1ff97e410a * LightSmsTransport.php - build signature and use http_build_query, timestamp int 1c993b7224 * ERROR_CODES -> int * www. - bug * isset validate ['error'] 1b59a7d47e * LightSmsTransport.php - string param 58ac708d0f * LightSmsTransport.php - return back www (without will not work). Now fail tests b9f9ff8c94 * LightSmsTransport.php - tests fail 265f776394 * LightSmsTransport.php - issue with Symfony\Component\Notifier\Bridge\LightSms\Tests\LightSmsTransportTest 23a446a2e1 * LightSmsTransport.php - issue with Symfony\Component\Notifier\Bridge\LightSms\Tests\LightSmsTransportTest 08235e5a3c * LightSmsTransport.php - bug fix 80ef5ba565 * LightSmsTransport.php - Unable to send the SMS: Closing direction to the user 08b0729751 Update LightSmsTransport.php 7180c1f400 Update LightSmsTransport.php f16b4d2aa2 * phone changed to from 7f13dbf711 * sender changed to from e20ef1ed35 * LightSmsTransport.php - change + to 00 b0e64b9250 * LightSmsTransport.php - not ok throw exception fc13bb27e2 * LightSmsTransport.php - changed login for validation (the same like we have all places) 5d2e6928f3 * LightSmsTransport.php - escape phone number 8620e828a7 * LightSmsTransport.php - move timestamp 66c34baf03 Update README.md 2e0e1d733d Update README.md 7b51e0dd7f Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 079406ed3d Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 0e41bc9186 Update src/Symfony/Component/Notifier/Bridge/LightSms/Tests/LightSmsTransportFactoryTest.php 3d0d79cfe2 Update src/Symfony/Component/Notifier/Bridge/LightSms/Tests/LightSmsTransportFactoryTest.php e0a68bd0ac Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 1b073c2366 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php b0891be0b2 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 49b4780f40 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php b2e46387b7 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php c02dbbd963 Update src/Symfony/Component/Notifier/Bridge/LightSms/README.md 9f89014d94 Update src/Symfony/Component/Notifier/Bridge/LightSms/README.md 5e54dfe475 * LightSmsTransport.php - quick fix for private constant. 3cbbc85e43 * HOST split into two parts 9e1809e6ae * small changes febff4613d Update src/Symfony/Component/Notifier/Bridge/LightSms/LICENSE 4a11b945a3 * github account author 728a3e2450 * Transport.php - missing use ce41756a6c * notifier_transports.php - Coding Standard d1ccd46e75 * Attached file changes which are required to run the lightsms notifier a0fae7dc4a * tests 15686c0851 * LightSmsTransport.php - Coding Standard 2f65b92cba * LightSmsTransport.php - Coding Standard 6792535a52 * composer.json - requirements bug fix 167f325f40 * LightSmsTransport.php - logic error be8f994fca * LightSmsTransport.php - return type f2ba226b46 * LightSmsTransport.php - bug fix b075c0eae2 * LightSms notifier
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Apr 6, 2021
…, StaffNowa) This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Add LightSms notifier bridge | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | License | MIT | Doc PR | symfony/symfony-docs/pull/15178 | Recipe PR | symfony/recipes#921 LightSms notifier https://github.com/D4DLab/lightsms-notifier Commits ------- 37c665eb5c * LightSmsTransport.php - make fabbot happy 68a12fa4f4 * fix tests f1f83b9e5c * LightSmsTransport.php - use query string parameters 026dcd97a9 * LightSmsTransport.php - isset 2a9ac2d92a * LightSmsTransport.php - fix 4213564be1 * composer.json - fix Fabien comment from another pull request #40646 21e972a69e * coding standard bea5256cc2 * type cast. On success lightsms return error code like string. On error return integer. 9b2e2d0b4a * type cast. On success lightsms return error code like string. On error return integer. 0d7488b10a * type cast. On success lightsms return error code like string. On error return integer. 9a832ef595 * LightSmsTransport.php - via mistake removed www which return (Closing direction to the user). Removed additional isset which in reality not needed. Added new method which allow to return "unknown error" and throw exception if not successfully 178d9c2a5a * pull request #40696 95e82f6ef1 Update LightSmsTransport.php a197deeed1 * LightSmsTransport.php - better to remove if we do not have it? 83d259832b * Coding Standard patch 1ff97e410a * LightSmsTransport.php - build signature and use http_build_query, timestamp int 1c993b7224 * ERROR_CODES -> int * www. - bug * isset validate ['error'] 1b59a7d47e * LightSmsTransport.php - string param 58ac708d0f * LightSmsTransport.php - return back www (without will not work). Now fail tests b9f9ff8c94 * LightSmsTransport.php - tests fail 265f776394 * LightSmsTransport.php - issue with Symfony\Component\Notifier\Bridge\LightSms\Tests\LightSmsTransportTest 23a446a2e1 * LightSmsTransport.php - issue with Symfony\Component\Notifier\Bridge\LightSms\Tests\LightSmsTransportTest 08235e5a3c * LightSmsTransport.php - bug fix 80ef5ba565 * LightSmsTransport.php - Unable to send the SMS: Closing direction to the user 08b0729751 Update LightSmsTransport.php 7180c1f400 Update LightSmsTransport.php f16b4d2aa2 * phone changed to from 7f13dbf711 * sender changed to from e20ef1ed35 * LightSmsTransport.php - change + to 00 b0e64b9250 * LightSmsTransport.php - not ok throw exception fc13bb27e2 * LightSmsTransport.php - changed login for validation (the same like we have all places) 5d2e6928f3 * LightSmsTransport.php - escape phone number 8620e828a7 * LightSmsTransport.php - move timestamp 66c34baf03 Update README.md 2e0e1d733d Update README.md 7b51e0dd7f Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 079406ed3d Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 0e41bc9186 Update src/Symfony/Component/Notifier/Bridge/LightSms/Tests/LightSmsTransportFactoryTest.php 3d0d79cfe2 Update src/Symfony/Component/Notifier/Bridge/LightSms/Tests/LightSmsTransportFactoryTest.php e0a68bd0ac Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 1b073c2366 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php b0891be0b2 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 49b4780f40 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php b2e46387b7 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php c02dbbd963 Update src/Symfony/Component/Notifier/Bridge/LightSms/README.md 9f89014d94 Update src/Symfony/Component/Notifier/Bridge/LightSms/README.md 5e54dfe475 * LightSmsTransport.php - quick fix for private constant. 3cbbc85e43 * HOST split into two parts 9e1809e6ae * small changes febff4613d Update src/Symfony/Component/Notifier/Bridge/LightSms/LICENSE 4a11b945a3 * github account author 728a3e2450 * Transport.php - missing use ce41756a6c * notifier_transports.php - Coding Standard d1ccd46e75 * Attached file changes which are required to run the lightsms notifier a0fae7dc4a * tests 15686c0851 * LightSmsTransport.php - Coding Standard 2f65b92cba * LightSmsTransport.php - Coding Standard 6792535a52 * composer.json - requirements bug fix 167f325f40 * LightSmsTransport.php - logic error be8f994fca * LightSmsTransport.php - return type f2ba226b46 * LightSmsTransport.php - bug fix b075c0eae2 * LightSms notifier
|
Thanks for your work on this new feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LightSMS symfony/symfony#40607