Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Messenger] Multiple failed transports #15177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

monteiro
Copy link
Contributor

@monteiro monteiro commented Apr 1, 2021

New Feature: Messenger: Multiple Failure Transports Transports

closes #15168

This PR adds the documentation related to PR: symfony/symfony#38468

What it needs to be clear in the documentation:

  • You can define multiple transports, one per transport (instead of the global one, as it is supported today)
  • If you don't define a global failure transport and if the transport does not have the failure_transport configured the messages will be discarded
  • If you define both a global and at the transport level, the failure_transport configuration, the one taken into account is at the transport level configuration.
  • The failed commands have an option argument to specify the transport level --transport. Without arguments is the global failed transport taken into account.

@monteiro monteiro changed the title Messenger multiple failed transports2 [Messenger] Multiple failed transports Apr 1, 2021
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Several small things - wonderful start!

messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
@monteiro monteiro requested a review from weaverryan April 3, 2021 16:00
@monteiro
Copy link
Contributor Author

monteiro commented Apr 3, 2021

@weaverryan should we put a warning or something that this was introduced on symfony 5.3? Or it is not needed.

messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments from my side

@monteiro monteiro requested a review from OskarStark April 6, 2021 14:20
messenger.rst Show resolved Hide resolved
@javiereguiluz javiereguiluz force-pushed the messenger-multiple-failed-transports2 branch from f3ae9ed to d784895 Compare April 20, 2021 15:58
@javiereguiluz javiereguiluz merged commit af4c0f7 into symfony:5.x Apr 20, 2021
@javiereguiluz
Copy link
Member

Hugo, thanks a lot for contributing these docs ... and congrats on your first Symfony Docs contribution 🎉 What a great first contribution! Cheers!

Oskar, we added the versionadded directive while merging.

@monteiro
Copy link
Contributor Author

Thanks a lot for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Messenger] Failure transports documentation
5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.