Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

docs(http-client): fix default retry_failed configuration example #15153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

KalleV
Copy link
Contributor

@KalleV KalleV commented Mar 25, 2021

The framework bundle configuration validation requires the top-level http client retry_failed configuration to be nested under default_options or scoped_clients.

See: https://github.com/symfony/framework-bundle/blob/1f977bb1b790f915b22462e511b039fb761280b3/DependencyInjection/Configuration.php#L1414

The framework bundle configuration validation requires the top-level http client retry_failed configuration to be nested under default_options or scoped_clients.

See: https://github.com/symfony/framework-bundle/blob/1f977bb1b790f915b22462e511b039fb761280b3/DependencyInjection/Configuration.php#L1414
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

This PR might be easier to review without whitespace: https://github.com/symfony/symfony-docs/pull/15153/files?w=1

@OskarStark
Copy link
Contributor

Good catch, thanks @KalleV.

@OskarStark OskarStark merged commit 6bd8350 into symfony:5.2 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.