Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Notifier] Add gatewayapi-notifier #14463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2021
Merged

[Notifier] Add gatewayapi-notifier #14463

merged 1 commit into from
Jan 14, 2021

Conversation

PGLongo
Copy link
Contributor

@PGLongo PGLongo commented Oct 22, 2020

Add gatewayapi-notifier documentation

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thank you.

We just need to wait for the code PR to get merged.

@OskarStark OskarStark added Waiting Code Merge Docs for features pending to be merged Notifier labels Oct 22, 2020
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move it above to stay alphabetically? Thanks

@OskarStark
Copy link
Contributor

OskarStark commented Oct 23, 2020

Sorry (I forgot), please change:

.. versionadded:: 5.2

-    The Smsapi, Infobip, Mobyt, Esendex and Sendinblue integrations were introduced in Symfony 5.2.
+    The Smsapi, GatewayAPI, Infobip, Mobyt, Esendex and Sendinblue integrations were introduced in Symfony 5.2.

@PGLongo
Copy link
Contributor Author

PGLongo commented Oct 23, 2020

Sorry (I forgot), please change:

.. versionadded:: 5.2

-    The Smsapi, Infobip, Mobyt, Esendex and Sendinblue integrations were introduced in Symfony 5.2.
+    The Smsapi, GatewayAPI, Infobip, Mobyt, Esendex and Sendinblue integrations were introduced in Symfony 5.2.

Done. Than you so much.

@PGLongo
Copy link
Contributor Author

PGLongo commented Nov 26, 2020

@OskarStark & @Nyholm since there is the RC of 5.2 should I update .. versionadded:: 5.2?

@OskarStark OskarStark added this to the 5.3 milestone Dec 11, 2020
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the name like in the code PR, thanks

notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
@carsonbot carsonbot changed the title Add gatewayapi-notifier [Notifier] Add gatewayapi-notifier Dec 11, 2020
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im happy with this after the changes Oskar asked for

notifier.rst Outdated Show resolved Hide resolved
@OskarStark
Copy link
Contributor

Thanks for the double check Tobias 👍

OskarStark added a commit to symfony/symfony that referenced this pull request Jan 14, 2021
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Notifier] Add GatewayApi bridge

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Replaces #38685
| License       | MIT
| Doc PR        | symfony/symfony-docs#14463
| Recipe PR        | symfony/recipes#864

Initial PR by @PGLongo

Commits
-------

6b9f721 [Notifier] Add GatewayApi bridge
@OskarStark OskarStark removed the Waiting Code Merge Docs for features pending to be merged label Jan 14, 2021
@OskarStark
Copy link
Contributor

Thank you Piergiuseppe.

@OskarStark OskarStark merged commit 9f046c8 into symfony:5.x Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.