-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Notifier] Add gatewayapi-notifier #14463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thank you.
We just need to wait for the code PR to get merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please move it above to stay alphabetically? Thanks
Sorry (I forgot), please change: .. versionadded:: 5.2
- The Smsapi, Infobip, Mobyt, Esendex and Sendinblue integrations were introduced in Symfony 5.2.
+ The Smsapi, GatewayAPI, Infobip, Mobyt, Esendex and Sendinblue integrations were introduced in Symfony 5.2. |
Done. Than you so much. |
@OskarStark & @Nyholm since there is the RC of 5.2 should I update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the name like in the code PR, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im happy with this after the changes Oskar asked for
Thanks for the double check Tobias 👍 |
This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Add GatewayApi bridge | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Replaces #38685 | License | MIT | Doc PR | symfony/symfony-docs#14463 | Recipe PR | symfony/recipes#864 Initial PR by @PGLongo Commits ------- 6b9f721 [Notifier] Add GatewayApi bridge
Thank you Piergiuseppe. |
Add gatewayapi-notifier documentation