Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Form] Add doc for the escape_label option #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2012
Merged

[Form] Add doc for the escape_label option #1442

merged 2 commits into from
Jun 17, 2012

Conversation

Dinduks
Copy link
Contributor

@Dinduks Dinduks commented Jun 9, 2012

Documentation for the feature added in symfony/symfony#4543

@stof
Copy link
Member

stof commented Jun 10, 2012

you need to add a ..versionnadded:: 2.1 note

weaverryan added a commit that referenced this pull request Jun 17, 2012
@weaverryan
Merge pull request #1442 from Dinduks/add_doc_for_escape_label
2ef93a4 
[Form] Add doc for the escape_label option
@weaverryan weaverryan merged commit 2ef93a4 into symfony:master Jun 17, 2012
weaverryan added a commit that referenced this pull request Jun 17, 2012
@weaverryan
[reference][forms] Tiny markup tweaks for #1442
558593c
@weaverryan
Copy link
Member

Hey Samy!

Another great PR for one of the many new features - I've merged this in. I've also opened up #1469 highlighting a few other changes I think we need in this area.

Thanks!

@Dinduks
Copy link
Contributor Author

Dinduks commented Jun 17, 2012

Hi Ryan,

The initial PR isn't merged yet, it is waiting for Fabien's approbation. Would you mind pinging him in there? :)

Thanks!

@weaverryan
Copy link
Member

Ah yes, I jumped prematurely - my mistake!

I'm going to revert this for now just to be accurate. @Dinduks can you ping me when the other PR is merged?

Thanks!

@Dinduks
Copy link
Contributor Author

Dinduks commented Jun 17, 2012

Sure, I will.

weaverryan added a commit that referenced this pull request Jun 17, 2012
@weaverryan
Reverting PR #1442 - this PR was merged prematurely. This reverts the…
a16022c 
… following commits:

sha: 8036ff1
sha: 4bf8cc8
sha: 558593c
@stof
Copy link
Member

stof commented Jun 17, 2012

@Dinduks you will need to rebase your commit otherwise merging your branch again will not make the change because the revert is later in the history now.

@weaverryan
Copy link
Member

But we can wait until the main PR is merged - in case it's not, no reason to go to the trouble now.

Cheers!

@Dinduks Dinduks mentioned this pull request Oct 13, 2012
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dinduks @stof @weaverryan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.