Document usage of Symfony Mailer for error email #14360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error: You are not allowed to use version "3.6.0". Only major version "5" is allowed. Error: Please only provide ".. versionadded::" if the version is greater/equal "5.0"
OskarStark
reviewed
Oct 6, 2020
OskarStark
approved these changes
Oct 7, 2020
|
thx @OskarStark :) just what do you think of the same sentence on the 4.4 code? should we alter the wording? |
|
Thanks Antoine! This is now merged in 5.1 and 5.x. You are right about tweaking the message in 4.4 version, so we did that in 70c96fb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to symfony/monolog-bundle#354
and symfony/monolog-bundle#354 (comment)
Should we also document that for the
v4.4of this page, it will not be possible?The
Symfony\Bridge\Monolog\Handler\MailerHandlerwas added inv5.1(symfony/symfony#33456)Because the wording
compatible yetimplies that it will be compatible in the futureThank you
edit: I do not understand the
DOCtor-RSTcheck here :s