Add information about resolver argument priority #14069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
reviewed
Aug 13, 2020
ogizanagi
approved these changes
Aug 14, 2020
| @@ -239,6 +239,7 @@ priority of 100. As this one is responsible for fetching attributes from the | ||
| lower priority. This makes sure the argument resolvers are not triggered when | ||
| the attribute is present. For instance, when passing the user along a | ||
| sub-requests. | ||
| However, if the injected parameter is an attribute of the request, it is necessary to set a priority of at least 100 otherwise the resolver will not be launched. |
There was a problem hiding this comment.
Suggested change
| However, if the injected parameter is an attribute of the request, it is necessary to set a priority of at least 100 otherwise the resolver will not be launched. | |
| However, if the argument is resolved from a request attribute, it is necessary to set a priority of at least 100 otherwise the resolver will not be executed. |
?
|
Hugo, thanks for your contribution to help this description. While merging, we made more rewords because the original paragraph was a bit confusing, but we kept most of your contribution. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes symfony/symfony#37799