Template subdirs #1324
Merged
Template subdirs #1324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $templating = $this->get('templating'); | ||
| $content = $templating->render('AcmeHelloBundle:Hello:index.html.twig', array('name' => $name)); | ||
| $content = $templating->render('AcmeHelloBundle:Hello/Greetings:index.html.twig', array('name' => $name)); |
There was a problem hiding this comment.
Why not having them both? Give first a simple example and make it more complex and the second one.
I think it is better to place it in a note.
|
I'm luke-warm on this idea. I do want people to know that this is certainly possible, but it's not something that I actually want to recommend that people do - it's an extra level of organization that is often unnecessary and makes your code more difficult to go through. So, perhaps we can modify things to be a little side-note and make it clear that it's not necessarily recommended, but certainly possible. Thanks! |
|
Amended the commit, should be a little closer now, I think. |
|
Love it - thanks Dan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed that for whatever reason the AcmeHelloBundle:Blah:Blah.html.twig syntax seems to not lend itself to people realizing they can still use a subdirectory even beneath "views/Blah" level.
See "cons" here:
http://www.reddit.com/r/PHP/comments/sx3fk/symfony2_experiences/c4hvwae