Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Validator] Documented the Hostname constraint #13167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2020
Merged

[Validator] Documented the Hostname constraint #13167

merged 1 commit into from
Feb 20, 2020

Conversation

javiereguiluz
Copy link
Member

Fixes #12923.

@javiereguiluz javiereguiluz added this to the 5.1 milestone Feb 17, 2020
OskarStark
OskarStark reviewed Feb 17, 2020
View reviewed changes
reference/constraints/Hostname.rst Show resolved Hide resolved
reference/constraints/Hostname.rst Show resolved Hide resolved
reference/constraints/Hostname.rst Outdated Show resolved Hide resolved
reference/constraints/Hostname.rst Outdated Show resolved Hide resolved
reference/constraints/Hostname.rst Outdated Show resolved Hide resolved
noniagriconomie
noniagriconomie reviewed Feb 17, 2020
View reviewed changes
reference/constraints/Hostname.rst Outdated Show resolved Hide resolved
OskarStark
OskarStark requested changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one error left:

Warning, treated as error:
/home/runner/work/symfony-docs/symfony-docs/reference/constraints/Hostname.rst:: WARNING: document isn't included in any toctree

@javiereguiluz
Copy link
Member Author

Oskar, I don't understand the error message because I linked the file from this file: https://github.com/symfony/symfony-docs/pull/13167/files#diff-5c99f0007238ae4a681869aa8713c3fd

@OskarStark
Copy link
Contributor

You need to add it here too:

https://github.com/symfony/symfony-docs/blob/master/reference/constraints.rst

HeahDude
HeahDude approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the toctree

@OskarStark
Copy link
Contributor

@javiereguiluz can you please squash or at least your two commits? Otherwise I cannot merge this, thanks!

@HeahDude
Copy link
Contributor

Thanks Javier.

@HeahDude HeahDude merged commit d0b800f into symfony:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noniagriconomie noniagriconomie noniagriconomie left review comments

@OskarStark OskarStark OskarStark approved these changes

@HeahDude HeahDude HeahDude approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review Validator
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Validator] Added HostnameValidator
5 participants
@javiereguiluz @OskarStark @HeahDude @noniagriconomie @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.