[Messenger] Transports in separate packages #13006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -730,6 +730,14 @@ options. | ||
| AMQP Transport | ||
| ~~~~~~~~~~~~~~ | ||
|
|
||
| .. versionadded:: 5.1 | ||
|
|
||
| The AMQP transport has moved to a separate package. Install it by running |
There was a problem hiding this comment.
I like this ... but I'd be more explicit in the message. The current proposal will only display 5.1 (because of the versionadded directive) and the message ... so we could reword it like this to be more clear about when this change will happen:
.. versionadded:: 5.1
Starting from Symfony 5.1, the AMQP transport has moved to a separate package.
Install it by running:78a7dae to
6a54402
Compare
|
Thanks Tobias! |
maxhelias
reviewed
Mar 4, 2020
|
|
||
| The AMQP transport has moved to a separate package. Install it by running | ||
|
|
||
| .. code-block:: terminal |
There was a problem hiding this comment.
The rendering of a "code-block" inside a "versionadded" is not very well supported.
I have this rendering :
There was a problem hiding this comment.
It would be better to have something like this :
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a note that transports will be in separate packages from 5.1.
Im not sure this is the best way to present it. Soon, new transports will be added. They should also start with a:
Anyhow, this is good for these 3, that is why I submitting the PR and hope for feedback.
This will fix #12998