Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Console] Mention that CommandTester doesn't dispatch console events #12797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2019
Merged

[Console] Mention that CommandTester doesn't dispatch console events #12797

merged 1 commit into from
Dec 10, 2019

Conversation

javiereguiluz
Copy link
Member

Fixes #11828.

@javiereguiluz javiereguiluz added this to the 3.4 milestone Dec 10, 2019
OskarStark
OskarStark approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dmaicher

dmaicher
dmaicher approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 thanks

javiereguiluz added a commit that referenced this pull request Dec 10, 2019
@javiereguiluz
minor #12797 [Console] Mention that CommandTester doesn't dispatch co…
3e73d30 
…nsole events (javiereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Mention that CommandTester doesn't dispatch console events

Fixes #11828.

Commits
-------

c070711 [Console] Mention that CommandTester doesn't dispatch console events
@javiereguiluz javiereguiluz merged commit c070711 into symfony:3.4 Dec 10, 2019
@javiereguiluz javiereguiluz deleted the fix_11828 branch December 10, 2019 16:15
@javiereguiluz javiereguiluz mentioned this pull request Dec 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaicher dmaicher dmaicher approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @dmaicher @OskarStark @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.