Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix UnicodeString::fromCodePoints() example #12791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

jdreesen
Copy link
Contributor

@jdreesen jdreesen commented Dec 9, 2019

UnicodeString::fromCodePoints() returns a UnicodeString so the next line // $foo = 'नमस्ते' is not correct as it implies the result to be a string.

Thus, the result should be casted to a string (or ->toString() should be called) to match the comment.

components/string.rst Show resolved Hide resolved
@OskarStark OskarStark added this to the 5.0 milestone Dec 10, 2019
components/string.rst Show resolved Hide resolved
javiereguiluz added a commit that referenced this pull request Dec 10, 2019
This PR was merged into the 5.0 branch.

Discussion
----------

Fix `UnicodeString::fromCodePoints()` example

`UnicodeString::fromCodePoints()` returns a `UnicodeString` so the next line `// $foo = 'नमस्ते'` is not correct as it implies the result to be a `string`.

Thus, the result should be casted to a `string` (or `->toString()` should be called) to match the comment.

Commits
-------

6793fbe Fix UnicodeString::fromCodePoints example
@javiereguiluz javiereguiluz merged commit 6793fbe into symfony:5.0 Dec 10, 2019
@jdreesen jdreesen deleted the patch-2 branch December 10, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.