Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update parent_services.rst #12742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2019
Merged

Update parent_services.rst #12742

merged 1 commit into from
Dec 2, 2019

Conversation

amine-betari
Copy link
Contributor

No description provided.

javiereguiluz
javiereguiluz approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amine-betari good catch! Thanks for fixing it.

Note to mergers: merge in 3.4.

@javiereguiluz javiereguiluz added this to the 3.4 milestone Dec 2, 2019
@OskarStark OskarStark changed the base branch from 4.4 to 3.4 December 2, 2019 10:40
@OskarStark
Copy link
Contributor

Thank you @amine-betari for taking care of this regression.

OskarStark added a commit that referenced this pull request Dec 2, 2019
@OskarStark
bug #12742 Update parent_services.rst (amine-betari)
df13346 
This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead (closes #12742).

Discussion
----------

Update parent_services.rst

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

833ed5e Update parent_services.rst
@OskarStark OskarStark merged commit 833ed5e into symfony:3.4 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@amine-betari @OskarStark @javiereguiluz @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.