fix BrowserKit Client to AbstractBrowser rename #12717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Nov 29, 2019
Contributor
|
I propose to add this change to |
Co-Authored-By: Oskar Stark <oskarstark@googlemail.com>
Contributor
|
Could you add the deprecated directive @jzawadzki and change the base branch to 4.3? |
Contributor
Author
|
will do today |
Contributor
|
Hello @jzawadzki are you still willing to work on this PR? Thanks! |
This was referenced Apr 13, 2020
javiereguiluz
added a commit
that referenced
this pull request
Jun 8, 2020
…bstractBrowser since SF 4.3 (Calex92) This PR was merged into the 4.4 branch. Discussion ---------- [Browserkit] The Client class has been replaced by the AbstractBrowser since SF 4.3 I noticed that in the BrowserKit documentation, there was multiple references to the old ``Symfony\Component\BrowserKit\Client`` class instead of the ``Symfony\Component\BrowserKit\AbstractBrowser`` one. See [https://github.com/symfony/symfony/pull/30541](https://github.com/symfony/symfony/pull/30541) There was a previous merge request for SF5 here (#12717), but I don't know if it was possible for me to use it since I'm quite new with Github best practice about contribution. Don't hesitate to tell me if I'm wrong! Commits ------- a3ff4e0 The Client class has been replaced by the AbstractBrowser since SF 4.3
Member
|
@jzawadzki thanks for contributing these fixes. Sadly we received another pull request targeted at an earlier branch, which allowed us to add the "deprecated" directive (see #13550). So, we're closing this in favor of the other one. @OskarStark we added the deprecated directive while merging and removed it in 5.0 and up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per symfony/symfony#30541
Clienthas been renamed toAbstractBrowser. Looks like docs were not updated