Middleware clarification about being called on "receive" #12535
Conversation
|
Thanks @weaverryan! Few questions on my end:
|
I added some details there, but it was actually already shown in an example.
What do you mean by this? |
For example the doctrine ping connection middleware should say that it is triggered only when the message is handled by the worker otherwise it will do nothing. It's a bit out of the scope of this PR though. |
Perhaps - it would be a comment in the core class. But the class is also pretty small, and if you're wiring it up manually (e.g. not using the DoctrineBundle integration), then you'll probably look inside the class anyways. It doesn't seem too important to me to document anywhere. |
14f6c5b to
b9f315f
Compare
|
Thanks Ryan. |
… (weaverryan) This PR was squashed before being merged into the 4.3 branch (closes #12535). Discussion ---------- Middleware clarification about being called on "receive" Hi! A clarification that middleware may be called twice. I think this is the best spot, and isn't too big or too small. Commits ------- b9f315f Middleware clarification about being called on \"receive\"
Hi!
A clarification that middleware may be called twice. I think this is the best spot, and isn't too big or too small.