Documenting ErrorRenderer and ErrorHandler components #12187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a0d170 to
2c78789
Compare
8123fd8 to
5136a17
Compare
|
It's targeted master, it's should be on 4.4 ? |
|
Yes 4.4 👍🏻 |
yceruto
commented
Aug 19, 2019
| available, the handler uses a Symfony Response object; if not, it falls | ||
| back to a regular PHP response. | ||
|
|
||
| Catches PHP errors and turn them into exceptions |
There was a problem hiding this comment.
btw, documenting symfony/symfony#33155, close #12193
@wouterj could you please leave some feedback here? Thanks. |
|
I have some proposals to reword some things and to change some sections ... but I prefer to do that in a separate PR to allow others to review the proposed changes. That's why I'm merging this "as is". Yonel, thanks a lot for such a nice contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Sep 19, 2019
…aviereguiluz, yceruto) This PR was merged into the 4.4 branch. Discussion ---------- Documenting ErrorRenderer and ErrorHandler components Replace #11864 Closes #12193 #12009 #11980 #12015 #12019 #12029 Should we remove the whole Debug component documentation? or remove only the details and say it's deprecated? Commits ------- 8cc084f documenting the ErrorHandler::call method 3ea9817 fix service definition 5a025c9 fix example 5136a17 Update with latest changes: ErrorRenderer and ErrorHandler components b0723ef Fixed a method name b600b3c Renamed ErrorCatcher as ErrorRenderer 4e333c1 Fixes b2a1a9b Documented the ErrorCatcher component
This was referenced Sep 19, 2019
javiereguiluz
added a commit
that referenced
this pull request
Sep 20, 2019
…onents (javiereguiluz) This PR was squashed before being merged into the 4.4 branch (closes #12344). Discussion ---------- Some rewords for the ErrorHandler and ErrorRenderer components This continues #12187 with some rewords. Commits ------- 6220b48 Some rewords for the ErrorHandler and ErrorRenderer components
This was referenced Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #11864
Closes #12193 #12009 #11980 #12015 #12019 #12029
Should we remove the whole Debug component documentation? or remove only the details and say it's deprecated?