[4.3] Update workflow config #12146
Merged
[4.3] Update workflow config #12146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wouterj
added a commit
that referenced
this pull request
Aug 12, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [4.3] Update workflow config Rescued some really bad git stuff from me while merging: #11580 Original description: > Hi, > > This draft PR follows this one > https://github.com/symfony/symfony-docs/pull/11492/files (config for 3.X version) > but for new version, mostly 4.3 > > I checked this PR also > symfony/symfony#30890, @lyrixx review appreciated please > > Maybe to merge after merging #11578, and with a rebase ? > > -------------------- > > Draft for now > > - Closes #11229 > > this one can be closed also: > > - Closes #9475 > - Closes #10197 Commits ------- fdc221b Minor XML improvement a640d14 [Workflow] config doc 7bb2041 Fix indent f65f1bc Review cf3a32c Doc config metadata 34e7cc5 [Workflow] config doc
| @@ -79,10 +79,11 @@ Usage | ||
| ----- | ||
|
|
||
| When you have configured a ``Registry`` with your workflows, | ||
| you can retrieve a workflow from it and use it as follows:: | ||
| you can retreive a workflow from it and use it as follows:: |
There was a problem hiding this comment.
It looks like retrieve is the right orthography.
|
|
||
| // ... | ||
| // Consider that $blogPost is in place "draft" by default | ||
| // Consider that $post is in state "draft" by default |
There was a problem hiding this comment.
The variable $post doesn't exist.
There was a problem hiding this comment.
yes i updated it in another PR, and on the original one i added this line
which then create a fail merge :/
|
Would you send a PR? |
noniagriconomie
added a commit
to noniagriconomie/symfony-docs
that referenced
this pull request
Aug 13, 2019
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 13, 2019
* 4.3: Added the LICENSE file Added the Code of Conduct file [symfony#12146] fix typos
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 13, 2019
* 4.4: Added the LICENSE file Added the Code of Conduct file [symfony#12146] fix typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rescued some really bad git stuff from me while merging: #11580
Original description: