Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Routing] Be consistent in custom route loader doc #11986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

fancyweb
Copy link
Contributor

To be consistent with the above name "The routes defined using service route loaders will be automatically..." + cf symfony/symfony#32598 (comment)

@javiereguiluz javiereguiluz added this to the 4.3 milestone Jul 19, 2019
@javiereguiluz
Copy link
Member

Minor ... but nice for consistency. Thanks Thomas!

@javiereguiluz javiereguiluz merged commit d60e4f6 into symfony:4.3 Jul 19, 2019
javiereguiluz added a commit that referenced this pull request Jul 19, 2019
…yweb)

This PR was merged into the 4.3 branch.

Discussion
----------

[Routing] Be consistent in custom route loader doc

To be consistent with the above name "The routes defined using service route loaders will be automatically..." + cf symfony/symfony#32598 (comment)

Commits
-------

d60e4f6 [Routing] Be consistent in custom route loader doc
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Jul 23, 2019
This PR was merged into the 4.3 branch.

Discussion
----------

[Routing] Fix CHANGELOG

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Minor but cf symfony/symfony-docs#11986 - details make perfection 😁

Commits
-------

8b1d6cd [Routing] Fix CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.