Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix indention #11508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2019
Merged

fix indention #11508

merged 1 commit into from
May 3, 2019

Conversation

OskarStark
Copy link
Contributor

No description provided.

@OskarStark OskarStark added this to the 3.4 milestone May 2, 2019
@OskarStark OskarStark force-pushed the indention branch 6 times, most recently from 1498080 to 2da8031 Compare May 2, 2019 11:10
@@ -93,23 +93,23 @@ The ``match()`` method takes a request path and returns an array of attributes
(notice that the matched route is automatically stored under the special
``_route`` attribute)::

print_r($matcher->match('/bye'));
/* Gives:
$matcher->match('/bye');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the print_r is not needed here

Explains the steps to follow to contribute fixes and new contents. It's the
same contribution process followed by most open source projects, so you may
already know everything that is needed.
Explains the steps to follow to contribute fixes and new contents. It's the
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result is the same and we should use 4 spaces for indention whenever we can

@javiereguiluz
Copy link
Member

Nice work here! Thank you Oskar.

@javiereguiluz javiereguiluz merged commit cbe6e45 into symfony:3.4 May 3, 2019
javiereguiluz added a commit that referenced this pull request May 3, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

fix indention

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

cbe6e45 fix indention
@OskarStark OskarStark deleted the indention branch May 3, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.