Workflow configuration #11492

noniagriconomie · Apr 25, 2019

Hi,

Related to #11043
I can also provide the 4.3 update (when 4.3 is feature freezed ? should we do 4.1/4.2 ?)

The review can be difficult as I reordered some parts, better read it on the SymfonyCloud build

Cheers

noniagriconomie · Apr 25, 2019

friendly ping @lyrixx as codeowner of workflow, reviews/comments appreciated :)

javiereguiluz · Apr 25, 2019

@noniagriconomie thanks for working on this! Sadly, we cannot reorder the options as proposed. We should keep the alphabetical sorting, which is what we use in all listings of config options across the docs.

noniagriconomie · Apr 25, 2019

@javiereguiluz ha ok, understood, i reordered them as "config priority"
I will revert no problem

edit : reverted @javiereguiluz

reference/configuration/framework.rst

lyrixx

👍

reference/configuration/framework.rst

noniagriconomie · May 5, 2019

@OskarStark I am currently in vacations
Feel free to commit your suggestions and advance the PR 👍🏻
Edit : I will do the 4.3 version when this is merged
Thanks

reference/configuration/framework.rst

OskarStark · May 6, 2019

Feel free to commit your suggestions and advance the PR 👍🏻

Enjoy your vacation 🌴 ☀️ , we can apply the changes when merging this PR!

👍 from my side @javiereguiluz

This PR was merged into the 3.4 branch. Discussion ---------- Workflow configuration Hi, Related to #11043 I can also provide the 4.3 update (when 4.3 is feature freezed ? should we do 4.1/4.2 ?) The review can be difficult as I reordered some parts, better read it on the SymfonyCloud build Cheers Commits ------- 6282e97 Workflow configuration

javiereguiluz · May 6, 2019

Thanks Antoine! We merged this and made all changes proposed by @OskarStark while merging it.

carsonbot added the Status: Needs Review label Apr 25, 2019

noniagriconomie mentioned this pull request Apr 25, 2019

Complete the documentation of the workflow options #11043

Closed

noniagriconomie force-pushed the feature-workflow-config branch from af6bca2 to 1fc0b56 Compare April 25, 2019 12:35

noniagriconomie force-pushed the feature-workflow-config branch from 1fc0b56 to 992be34 Compare April 25, 2019 12:48

javiereguiluz added the Workflow label Apr 25, 2019

javiereguiluz added this to the 3.4 milestone Apr 25, 2019

noniagriconomie force-pushed the feature-workflow-config branch 3 times, most recently from ac87421 to eb7a4fc Compare April 26, 2019 08:08

Workflow configuration

6282e97

noniagriconomie force-pushed the feature-workflow-config branch from eb7a4fc to 6282e97 Compare April 26, 2019 08:13

noniagriconomie commented Apr 30, 2019

View reviewed changes