Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Workflow] rename Twig function #11375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2019
Merged

[Workflow] rename Twig function #11375

merged 1 commit into from
Apr 9, 2019

Conversation

cawolf
Copy link
Contributor

@cawolf cawolf commented Apr 9, 2019

Hey everyone,

this PR updates the Twig function name to the one which was introduced with symfony/symfony#30908

(relates to #11268)

@OskarStark OskarStark changed the base branch from master to 4.2 April 9, 2019 06:41
@OskarStark
Copy link
Contributor

OskarStark commented Apr 9, 2019

Thank you @cawolf, I merged it in the 4.2 branch instead 👍

@OskarStark OskarStark merged commit 930224a into symfony:4.2 Apr 9, 2019
OskarStark added a commit that referenced this pull request Apr 9, 2019
This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #11375).

Discussion
----------

[Workflow] rename Twig function

Hey everyone,

this PR updates the Twig function name to the one which was introduced with symfony/symfony#30908

(relates to #11268)

Commits
-------

930224a fix name of Twig function
@cawolf cawolf deleted the patch-workflow-transition-blockers branch April 9, 2019 07:39
@wouterj
Copy link
Member

wouterj commented Apr 9, 2019

@OskarStark are you sure that's correct? Seems like the function has been merged in 4.3: symfony/symfony@e5f14b7

@OskarStark
Copy link
Contributor

Ah damn, I double checked and he wanted to remove it in 4.2 and the diff against 4.2 looks correct too, but yes the method was merged in 4.3 instead, so this is my mistake...

wouterj added a commit that referenced this pull request Apr 9, 2019
* 4.2:
  [#11375] Removed the workflow_transition_blockers from 4.2 docs
wouterj added a commit that referenced this pull request Apr 9, 2019
wouterj added a commit that referenced this pull request Apr 9, 2019
@wouterj
Copy link
Member

wouterj commented Apr 9, 2019

No worries! Fyi, I've done the following:

  • Remove the twig section from the 4.2 docs, as the function does not exists: f673d4d
  • Reverted this removal in the 4.3 docs: 6eba77c
  • Added a versionadded directive indicating this is a new feature: 13c92ff

@OskarStark
Copy link
Contributor

Thank you very much Wouter for your help 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.