-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Workflow] rename Twig function #11375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
OskarStark
merged 1 commit into
symfony:4.2
from
cawolf:patch-workflow-transition-blockers
Apr 9, 2019
Merged
[Workflow] rename Twig function #11375
OskarStark
merged 1 commit into
symfony:4.2
from
cawolf:patch-workflow-transition-blockers
Apr 9, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Apr 9, 2019
relates to #11268
Thank you @cawolf, I merged it in the |
OskarStark
added a commit
that referenced
this pull request
Apr 9, 2019
This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #11375). Discussion ---------- [Workflow] rename Twig function Hey everyone, this PR updates the Twig function name to the one which was introduced with symfony/symfony#30908 (relates to #11268) Commits ------- 930224a fix name of Twig function
@OskarStark are you sure that's correct? Seems like the function has been merged in 4.3: symfony/symfony@e5f14b7 |
Ah damn, I double checked and he wanted to remove it in 4.2 and the diff against 4.2 looks correct too, but yes the method was merged in 4.3 instead, so this is my mistake... |
wouterj
added a commit
that referenced
this pull request
Apr 9, 2019
wouterj
added a commit
that referenced
this pull request
Apr 9, 2019
* 4.2: [#11375] Removed the workflow_transition_blockers from 4.2 docs
wouterj
added a commit
that referenced
this pull request
Apr 9, 2019
…cs" in 4.3 This reverts commit f673d4d.
wouterj
added a commit
that referenced
this pull request
Apr 9, 2019
Thank you very much Wouter for your help 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone,
this PR updates the Twig function name to the one which was introduced with symfony/symfony#30908
(relates to #11268)