[Validator] add documentation for the new Timezone constraint.
#11317
Conversation
12abdbf to
b0b1498
Compare
|
Thank you for creating this documentation PR alongside your code one! Besides adding it to |
|
|
||
| ========== ====================================================================== | ||
| Applies to :ref:`property or method <validation-property-target>` | ||
| Options - `groups`_ |
There was a problem hiding this comment.
@symfony/team-symfony-docs do we use ordered options here and the same order for the explanations?
There was a problem hiding this comment.
We didn't reorder descriptions for existing docs in the past and only sorted the table of contents to keep the diff maintainable. But here it makes sense to sort from the beginning.
There was a problem hiding this comment.
What do you mean?
Ordering options like:
- Child class options first then inherited options?
- The opposite order of
1.?
There was a problem hiding this comment.
@xabbuh although you are right ... for the Constraints docs we recently sorted both the list of options and their descriptions. It was a hell to fix all the conflicts, but we did it anyways :)
|
I reverted |
@wouterj In which category / section shall we classify this constraint? It's not really a date time validation constraint. |
|
I think the "Choice" category matches best (the |
|
Sounds good to me |
…phansys) This PR was merged into the 4.3-dev branch. Discussion ---------- [Validator] add new `Timezone` validation constraint | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT | Doc PR | symfony/symfony-docs#11317 Rework of #22262. Commits ------- 536e53f [Validator] add new `Timezone` validation constraint.
|
Please check Travis, maybe a rebase is needed? 🧐 |
…onstraint. (hhamon, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [Validator] add documentation for the new `Timezone` constraint. This is the documentation related to PR symfony/symfony#30900 Commits ------- 8e33d47 Fixes classification 5ec9159 Fix option ec7bd40 Revert country_code to countryCode 9cbeb75 Fixes options list table c5681bf Add more explanations b37bc78 Minor fixes d564218 Minor fixes ac6282f Listed the geographical zones defined by PHP 135c5ff Minor fixes b0b1498 [Validator] add documentation for the new `Timezone` constraint.
|
|
||
| class UserSettings | ||
| { | ||
| protected $timezone; |
There was a problem hiding this comment.
If I am correct, this should be removed as it is not added in other constraints
This is the documentation related to PR symfony/symfony#30900