Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

moved XSD to HTTPS - Part 2 #11296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2019
Merged

moved XSD to HTTPS - Part 2 #11296

merged 1 commit into from
Apr 6, 2019

Conversation

OskarStark
Copy link
Contributor

This is a follow up of #11122.

I double checked the doctrine and phpunit namespaces, and the are available
via https!

//cc @fabpot

@OskarStark
moved XSD to HTTPS - Part 2
c638c32 
This is a follow up of symfony#11122.

I double checked the doctrine and phpunit namespaces, and the are available
via https!

//cc @fabpot
@OskarStark OskarStark added this to the 3.4 milestone Apr 4, 2019
@OskarStark OskarStark requested a review from wouterj April 4, 2019 10:38
@wouterj
Copy link
Member

wouterj commented Apr 6, 2019

Great, thanks for the work! This will be the first #EU-FOSSA hackathon merge! 🎉

@wouterj wouterj merged commit c638c32 into symfony:3.4 Apr 6, 2019
wouterj added a commit that referenced this pull request Apr 6, 2019
@wouterj
minor #11296 moved XSD to HTTPS - Part 2 (OskarStark)
4b7dfec 
This PR was merged into the 3.4 branch.

Discussion
----------

moved XSD to HTTPS - Part 2

This is a follow up of #11122.

I double checked the doctrine and phpunit namespaces, and the are available
via https!

//cc @fabpot

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

c638c32 moved XSD to HTTPS - Part 2
@OskarStark
Copy link
Contributor Author

Honored that this is one of my PR’s 🤗🥰

@OskarStark OskarStark deleted the use-https-for-xsd branch April 6, 2019 09:14
@wouterj wouterj added the ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming label Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@gregurco gregurco gregurco approved these changes

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@OskarStark @wouterj @fabpot @javiereguiluz @gregurco @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.