Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Expanding on repositoryMethod #11029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

ThomasLandauer
Copy link
Contributor

No description provided.

javiereguiluz added a commit that referenced this pull request Feb 22, 2019
This PR was squashed before being merged into the 3.4 branch (closes #11029).

Discussion
----------

Expanding on repositoryMethod

Commits
-------

25d7a4a Expanding on repositoryMethod
@javiereguiluz
Copy link
Member

Thanks Thomas!

@ThomasLandauer ThomasLandauer deleted the patch-6 branch February 22, 2019 09:58
@ThomasLandauer
Copy link
Contributor Author

@javiereguiluz: Thanks for fixing "a fieldName => value associative array" - just noticed that I had it wrong yesterday ;-)

@javiereguiluz
Copy link
Member

No worries! We always tweak a bit some things while merging. We prefer to not report them in the review because it's annoying to contributors and we can easily fix them ourselves. Thanks!

@xabbuh xabbuh added this to the 3.4 milestone Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.