Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update testing.rst #10915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update testing.rst #10915

wants to merge 1 commit into from

Conversation

xavierkaitha94
Copy link
Contributor

By default there is no utill folder

@xavierkaitha94
Update testing.rst
ee76101 
By default there is no utill folder
kunicmarko20
kunicmarko20 reviewed Jan 21, 2019
View reviewed changes
Copy link
Contributor

@kunicmarko20 kunicmarko20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence starts with Suppose, for example, I don't think this edit is needed.

@javiereguiluz javiereguiluz mentioned this pull request Jan 21, 2019
Merged
@javiereguiluz
Copy link
Member

@xavierkaitha94 I agree with @kunicmarko20 and I think it's enough to say "suppose that...". However, the article contained a mention to "app bundle", which is wrong in 4.x docs, so I've created #10916 to fix it.

I'm sorry to close this without merging it ... but as you can see, it helped us find another error, so we thank your contribution! We're looking forward to future contributions from you. Thanks!

javiereguiluz added a commit that referenced this pull request Jan 22, 2019
@javiereguiluz
minor #10916 Minor reword in the testing article (javiereguiluz)
ebff601 
This PR was merged into the 4.1 branch.

Discussion
----------

Minor reword in the testing article

Let's remove any reference to "app bundle" in 4.x docs. Spotted thanks to #10915.

Commits
-------

136e329 Minor reword in the testing article
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunicmarko20 kunicmarko20 kunicmarko20 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xavierkaitha94 @javiereguiluz @kunicmarko20
Morty Proxy This is a proxified and sanitized view of the page, visit original site.