Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update PHPUnit documentation link #10186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update PHPUnit documentation link #10186

wants to merge 1 commit into from

Conversation

martixy
Copy link
Contributor

@martixy martixy commented Aug 15, 2018

No description provided.

@@ -974,7 +974,7 @@ Learn more
* :doc:`/components/css_selector`

.. _`PHPUnit`: https://phpunit.de/
.. _`documentation`: https://phpunit.de/manual/current/en/
.. _`documentation`: https://phpunit.de/documentation.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rather use https://phpunit.readthedocs.io/ instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'd consider it better to leave it on the page where it explains how to reach the docs for different languages and different versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO that's inconsistent with what we do elsewhere. We always link to the English version of docs we link to. For most users that saves one click and if you are interested in reading a localised version, it's easy to switch the language.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either's fine. This doesn't warrant that much of an extended discussion.

@javiereguiluz javiereguiluz added this to the 2.8 milestone Sep 4, 2018
javiereguiluz added a commit that referenced this pull request Sep 4, 2018
This PR was submitted for the 3.4 branch but it was merged into the 2.8 branch instead (closes #10186).

Discussion
----------

Update PHPUnit documentation link

Commits
-------

819fa1a Update PHPUnit documentation link
@javiereguiluz
Copy link
Member

@martixy thanks a lot for fixing this wrong link!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.