Update PHPUnit documentation link #10186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Aug 16, 2018
| @@ -974,7 +974,7 @@ Learn more | ||
| * :doc:`/components/css_selector` | ||
|
|
||
| .. _`PHPUnit`: https://phpunit.de/ | ||
| .. _`documentation`: https://phpunit.de/manual/current/en/ | ||
| .. _`documentation`: https://phpunit.de/documentation.html |
There was a problem hiding this comment.
Should we rather use https://phpunit.readthedocs.io/ instead?
There was a problem hiding this comment.
TBH I'd consider it better to leave it on the page where it explains how to reach the docs for different languages and different versions.
There was a problem hiding this comment.
IMO that's inconsistent with what we do elsewhere. We always link to the English version of docs we link to. For most users that saves one click and if you are interested in reading a localised version, it's easy to switch the language.
There was a problem hiding this comment.
Either's fine. This doesn't warrant that much of an extended discussion.
javiereguiluz
added a commit
that referenced
this pull request
Sep 4, 2018
|
@martixy thanks a lot for fixing this wrong link! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.