Also requiring annotations so they can be used #10174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5a5dcc to
89610c7
Compare
xabbuh
approved these changes
Aug 13, 2018
|
Thank you Ryan. |
xabbuh
added a commit
that referenced
this pull request
Aug 21, 2018
This PR was merged into the 4.1 branch. Discussion ---------- Also requiring annotations so they can be used It's an edge case, as most people use the `website-skeleton` or install the `annotations` (SensioFWExtra) package, but just in case, the user *does* need `doctrine/annotations` in order to support using annotations with validation - https://github.com/symfony/symfony/blob/f96753b9ab497a42f7a76188e2de4911b50f5407/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L744 Cheers! Commits ------- 89610c7 Also requiring annotations so they can be used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an edge case, as most people use the
website-skeletonor install theannotations(SensioFWExtra) package, but just in case, the user does needdoctrine/annotationsin order to support using annotations with validation - https://github.com/symfony/symfony/blob/f96753b9ab497a42f7a76188e2de4911b50f5407/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L744Cheers!