Fix mismatched list items #10161
Closed
Fix mismatched list items #10161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Item one was displaying with a "1)" while item two shows up as "2."
|
@aldenw well spotted! We merged it in 2.8 and later we'll merge it up into the upper branches. Congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Aug 8, 2018
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #10161). Discussion ---------- Fix mismatched list items Item one was displaying with a "1)" while item two shows up as "2." <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 2017489 Wrap long lines 90ce187 Fix mismatched list items
xabbuh
reviewed
Aug 9, 2018
| under your firewall. | ||
|
|
||
| 2) Update your authenticator to avoid authentication if the user is already authenticated: | ||
| 1. If you do *not* need authentication to be stored in the session, set |
There was a problem hiding this comment.
We could even use #. for all items. Then, we wouldn't need to enumerate ourselves (I think we do that mostly anywhere else).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Item one was displaying with a "1)" while item two shows up as "2."